feat: adds SetLogTimestampFormat to cli, implements #2795 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Apr 28, 2020
cli/cli.go
Outdated
| func SetLogTimestampFormat(format string) { | ||
| log.SetFormatter(&log.TextFormatter{ | ||
| TimestampFormat: format, | ||
| FullTimestamp: true, |
There was a problem hiding this comment.
@alexec d you mean the whole Formatter object? Something like this instead:
// SetFormatter sets the logrus log formatter
func SetFormatter(formatter log.Formatter) {
log.SetFormatter(formatter)
}
There was a problem hiding this comment.
I think he may mean that we might want to have a flag to set FullTimestamp on or off
|
Kudos, SonarCloud Quality Gate passed!
|
|
I don't think we need this PR - you can call logrus directly surely? |
|
@alexec you are absolutely right! sorry for putting this in the wrong place. I've opened a new PR on the argo repo - argoproj/argo-workflows#2950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves towards addressing Argo Workflows Issue #2796.
It adds the function
SetLogTimestampFormatwhich could easily be called with the desired millisecond timestamp format requested in the issue, but can be formatted in any way desired by users across the variousargoprojrepositories. The fact that it is a separate function means it will not break any existing code usingpkg./review @alexec @simster7