Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panics #3118

Closed
alexec opened this issue May 28, 2020 · 1 comment · Fixed by #3119
Closed

Fix panics #3118

alexec opened this issue May 28, 2020 · 1 comment · Fixed by #3119
Assignees
@alexec
Labels
type/bug

Comments

@alexec
Copy link
Contributor

alexec commented May 28, 2020 •
edited 

 controller | time="2020-05-27T23:58:02Z" level=warning msg="Error updating workflow: Operation cannot be fulfilled on workflows.argoproj.io \"test-cron-wf-basic-mj5bn\": StorageError: invalid object, Code: 4, Key: /registry/argoproj.io/workflows/argo/test-cron-wf-basic-mj5bn, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 73299ac8-7de4-48b5-b25d-ef1941ad8d2e, UID in object meta:  Conflict" namespace=argo workflow=test-cron-wf-basic-mj5bn
 controller | time="2020-05-27T23:58:02Z" level=info msg="Re-applying updates on latest version and retrying update" namespace=argo workflow=test-cron-wf-basic-mj5bn
 controller | E0527 23:58:02.422603   19236 runtime.go:76] Observed a panic: original workflow is not hydrated
 controller | goroutine 271 [running]:
 controller | k8s.io/apimachinery/pkg/util/runtime.logPanic(0x1628e80, 0x1ac7d80)

https://app.circleci.com/pipelines/github/argoproj/argo/4080/workflows/575ce35b-ed70-4512-bc31-2670d3fc51fc/jobs/25086/steps
@alexec alexec self-assigned this May 28, 2020
@alexec alexec changed the title Fix hydrator panic Fix panics May 28, 2020
@alexec

This comment has been minimized.

Sign in to view
alexec added a commit to alexec/argo-workflows that referenced this issue May 28, 2020
@alexec
fix(controller): Do not panic of woc.orig in not hydrated. Fixes argo…
f64a4a1 
…proj#3118
@alexec alexec mentioned this issue May 28, 2020
Merged
6 tasks
alexec added a commit that referenced this issue May 28, 2020
@alexec
fix(controller): Do not panic of woc.orig in not hydrated. Fixes #3118 (
e88124d 
#3119)
@alexec alexec mentioned this issue Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(controller): Do not panic if woc.orig in not hydrated. Fixes #3118 alexec/argo-workflows
1 participant
@alexec