Docs doesn't tell user differences between workflow Stop and Terminate behaviors

[bklaubos]

Summary

I expect CLI docs to tell end user differences between argo terminate and argo stop intentions and its expected behavior. I found none.

Diagnostics

What Kubernetes provider are you using?
AWS
What version of Argo Workflows are you running?
2.16

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

[simster7]

Feel free to submit a PR

[bklaubos]

I logged this bug because as end user, I don't know the difference between stop vs terminate workflow. Are they the same?. If not, what are the expected behaviours.

[alexec]

They seem to be related to "shutdown strategy".

• Terminate do not run any more node nodes in the workflow.
• Stop do not run any more nodes - except exit handlers.

I'm not clear what happens to running nodes.

[simster7]

I'm not clear what happens to running nodes.

In both cases running nodes are stopped.

Terminate stops the workflow immediately, while Stop stops the workflow but allows all exit handlers to run.

[knabben]

What about adding these notes to the Cobra helper? I can help with this ticket.

https://github.com/argoproj/argo/blob/master/cmd/argo/commands/terminate.go#L16
https://github.com/argoproj/argo/blob/master/cmd/argo/commands/stop.go#L27

[simster7]

Sure, that would be great. I would also find a place in the docs to add the same information