-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daemoned flag not removed and workflow not completed when daemon pod deleted. #4652
Comments
@lonsdale8734 have you seen this in the wild? Do you have steps to reproduce please? |
…d. Fixes (argoproj#4652) Signed-off-by: lons <lonsdale8734@gmail.com>
…d. Fixes (argoproj#4652) Signed-off-by: lons <lonsdale8734@gmail.com>
…d. Fixes (argoproj#4652) Signed-off-by: lons <lonsdale8734@gmail.com>
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. |
Summary
What happened/what you expected to happen?
Daemoned flag in
NodeStatus
not removed and workflow not completed when daemon pod deleted.When daemon pod deleted, code blow may be unreachable.
https://github.com/argoproj/argo/blob/v2.11.8/workflow/controller/operator.go#L1089
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
The text was updated successfully, but these errors were encountered: