Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemoned flag not removed and workflow not completed when daemon pod deleted. #4652

Closed
lonsdale8734 opened this issue Dec 5, 2020 · 2 comments
Labels

Comments

@lonsdale8734
Copy link
Contributor

lonsdale8734 commented Dec 5, 2020

Summary

What happened/what you expected to happen?

Daemoned flag in NodeStatus not removed and workflow not completed when daemon pod deleted.

When daemon pod deleted, code blow may be unreachable.

https://github.com/argoproj/argo/blob/v2.11.8/workflow/controller/operator.go#L1089


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@alexec
Copy link
Contributor

alexec commented Dec 7, 2020

@lonsdale8734 have you seen this in the wild? Do you have steps to reproduce please?

@lonsdale8734 lonsdale8734 changed the title Daemond flag not removed and workflow not completed when daemon pod deleted. Daemoned flag not removed and workflow not completed when daemon pod deleted. Dec 8, 2020
lonsdale8734 added a commit to lonsdale8734/argo that referenced this issue Dec 8, 2020
lonsdale8734 added a commit to lonsdale8734/argo that referenced this issue Dec 8, 2020
…d. Fixes (argoproj#4652)

Signed-off-by: lons <lonsdale8734@gmail.com>
lonsdale8734 added a commit to lonsdale8734/argo that referenced this issue Dec 15, 2020
…d. Fixes (argoproj#4652)

Signed-off-by: lons <lonsdale8734@gmail.com>
lonsdale8734 added a commit to lonsdale8734/argo that referenced this issue Dec 16, 2020
…d. Fixes (argoproj#4652)

Signed-off-by: lons <lonsdale8734@gmail.com>
@no-response
Copy link

no-response bot commented Dec 21, 2020

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@no-response no-response bot closed this as completed Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants