Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Origin Requests #4984

Closed
joyciep opened this issue Feb 1, 2021 · 3 comments · Fixed by #4990
Closed

Cross Origin Requests #4984

joyciep opened this issue Feb 1, 2021 · 3 comments · Fixed by #4990
Labels
type/feature Feature request

Comments

@joyciep
Copy link
Contributor

joyciep commented Feb 1, 2021

Summary

Allow CORS by adding a way to set the "Access-Control-Allow-Origin" headers

What change needs making?

Something like

argo-server --access-control-allow-origin="http://localhost:8080"

Use Cases

When would you use this?

For making requests from my web application to Argo under the origin of http://localhost:8080 for example.
I can issue a PR for this since this is just setting an HTTP header.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@joyciep joyciep added the type/feature Feature request label Feb 1, 2021
@alexec
Copy link
Contributor

alexec commented Feb 1, 2021

would you like to submit a PR to add this?

@alexec
Copy link
Contributor

alexec commented Feb 1, 2021

actually, this might be in v3.0?

@joyciep joyciep mentioned this issue Feb 2, 2021
1 task
@joyciep
Copy link
Contributor Author

joyciep commented Feb 2, 2021

would you like to submit a PR to add this?

Submitted a PR for this #4990. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants