feat: Set CORS headers #4990
feat: Set CORS headers #4990
Conversation
|
|
Signed-off-by: Joyce Anne Piscos <joycepiscos@gmail.com>
Signed-off-by: Joyce Anne Piscos <joycepiscos@gmail.com>
This reverts commit 9b148a7. Signed-off-by: Joyce Anne Piscos <joycepiscos@gmail.com>
Signed-off-by: Joyce Anne Piscos <joycepiscos@gmail.com>
server/apiserver/argoserver.go
Outdated
| return &httpServer | ||
| } | ||
|
|
||
| // configureCORS is a middleware for setting CORS headers |
There was a problem hiding this comment.
Looks good. Any reason to not insert this next to the x-frames-options code?
There was a problem hiding this comment.
I just want this middleware close to the callers. Should I move it?
There was a problem hiding this comment.
Look for where we already add headers suck as X-Frame-Options
There was a problem hiding this comment.
Okay found it. Should I not use the middleware and just call w.Header().Set() in static.go?
There was a problem hiding this comment.
Moved it near the x-frame-options code, kindly check.
There was a problem hiding this comment.
@joyciep After this change, are the CORS configured also for /api/ URI? If I am reading it right, it is only used for static.NewFilesServer, isn't it?
Signed-off-by: Joyce Anne Piscos <joycepiscos@gmail.com>
Set
Access-Control-Allow-Originheader by passing the allowed origins via--access-control-allow-originflagFixes #4984
Checklist: