Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: 7x CPU usage #5852

Closed
alexec opened this issue May 6, 2021 · 1 comment · Fixed by #5933
Closed

v3: 7x CPU usage #5852

alexec opened this issue May 6, 2021 · 1 comment · Fixed by #5933
Assignees
@alexec
Labels
type/bug

Comments

@alexec
Copy link
Contributor

alexec commented May 6, 2021

v3 has increased CPU usage by 7x. This appears to due to WorkflowSemaphoreKeysIndexFunc calling util.FromUnstructured

image
@alexec alexec added the type/bug label May 6, 2021
@alexec alexec self-assigned this May 10, 2021
@alexec
Copy link
Contributor Author

alexec commented May 18, 2021

After analysis, cb9676e seems likely candidate.

alexec added a commit to alexec/argo-workflows that referenced this issue May 18, 2021
@alexec
fix(controller): Revert cb9676e. Fixes argoproj#5852
8bb2936 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked a pull request May 18, 2021 that will close this issue
fix(controller): Revert cb9676e88. Fixes #5852 #5933
Merged
alexec added a commit that referenced this issue May 18, 2021
@alexec
fix(controller): Revert cb9676e. Fixes #5852 (#5933)
56b71d0 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this issue May 21, 2021
Closed
14 tasks
alexec added a commit that referenced this issue May 24, 2021
@alexec
fix(controller): Revert cb9676e. Fixes #5852 (#5933)
49979c2 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this issue Jun 10, 2021
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(controller): Revert cb9676e88. Fixes #5852 alexec/argo-workflows
1 participant
@alexec