Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestGetPodByNode is flakey #6458

Closed
Tracked by #7133
alexec opened this issue Jul 30, 2021 · 7 comments · Fixed by #6763, #6783 or #6897
Closed
Tracked by #7133

TestGetPodByNode is flakey #6458

alexec opened this issue Jul 30, 2021 · 7 comments · Fixed by #6763, #6783 or #6897
Labels
area/build Build or GithubAction/CI issues P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important type/bug

Comments

@alexec
Copy link
Contributor

alexec commented Jul 30, 2021

This test is sporadically failing (10% of the time maybe).

Caused by: feat(controller): opt-in to sending pod node events as pod (#6377)
@alexec
Copy link
Contributor Author

alexec commented Jul 30, 2021

@josephmcgovern-wf could you please take a look if you have time?

@alexec
Copy link
Contributor Author

alexec commented Aug 4, 2021

bump!

@alexec alexec mentioned this issue Aug 4, 2021
Merged
@alexec
Copy link
Contributor Author

alexec commented Aug 13, 2021

This test is flakey.

alexec added a commit that referenced this issue Aug 13, 2021
@alexec
test: Skip TestGetPodByNode. See #6458
c27f668 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Copy link
Contributor Author

alexec commented Aug 13, 2021

I've commit a change to skip this test.

@sarabala1979 sarabala1979 mentioned this issue Sep 2, 2021
Closed
61 tasks
@sarabala1979 sarabala1979 mentioned this issue Sep 9, 2021
Closed
68 tasks
@alexec alexec linked a pull request Sep 21, 2021 that will close this issue
fix(controller): TestPodExists unit test #6763
Merged
@alexec
Copy link
Contributor Author

alexec commented Sep 21, 2021

@tczhao still seeing failures.

@tczhao tczhao mentioned this issue Sep 21, 2021
Merged
@tczhao tczhao mentioned this issue Sep 22, 2021
Closed
5 tasks
@micahbeeman-wf
Copy link
Contributor

@alexec @tczhao This issue was for TestGetPodByNode but was closed for a fix to TestPodExists. TestGetPodByNode is still skipped so this should be reopened.

@micahbeeman-wf
Copy link
Contributor

Also is there a link to one of the failures so we can fix TestGetPodByNode?

@alexec alexec reopened this Oct 8, 2021
@micahbeeman-wf micahbeeman-wf mentioned this issue Oct 14, 2021
Merged
@alexec alexec removed the triage label Oct 15, 2021
JPZ13 pushed a commit to JPZ13/argo-workflows that referenced this issue Oct 15, 2021
@micahbeeman-wf
fix(controller): Fix getPodByNode, TestGetPodByNode. Fixes argoproj#6458
41515d6 
 (argoproj#6897)

Signed-off-by: Micah Beeman <micah.beeman@workiva.com>
This was referenced Oct 15, 2021
Closed
Closed
sarabala1979 pushed a commit that referenced this issue Oct 19, 2021
@micahbeeman-wf @sarabala1979
fix(controller): Fix getPodByNode, TestGetPodByNode. Fixes #6458 (#6897)
d04aabf 
Signed-off-by: Micah Beeman <micah.beeman@workiva.com>
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this issue Oct 24, 2021
@micahbeeman-wf @kriti-sc
fix(controller): Fix getPodByNode, TestGetPodByNode. Fixes argoproj#6458
3276e15 
 (argoproj#6897)

Signed-off-by: Micah Beeman <micah.beeman@workiva.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
This was referenced Nov 2, 2021
Closed
Closed
@sarabala1979 sarabala1979 mentioned this issue Dec 15, 2021
Closed
73 tasks
@sarabala1979 sarabala1979 mentioned this issue Mar 1, 2022
Closed
@agilgur5 agilgur5 added area/build Build or GithubAction/CI issues P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important type/bug
Projects
None yet
Milestone
No milestone
3 participants
@alexec @micahbeeman-wf @agilgur5