Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with podname v2, pod.name resolves to incorrect name when using specpatch or retry #7007

Closed
tczhao opened this issue Oct 21, 2021 · 0 comments · Fixed by #7008
Closed

with podname v2, pod.name resolves to incorrect name when using specpatch or retry #7007

tczhao opened this issue Oct 21, 2021 · 0 comments · Fixed by #7008

Comments

@tczhao
Copy link
Member

tczhao commented Oct 21, 2021

when setting podname to v2, the resolved pod.name should contain template

metadata:
  namespace: argo
  name: steps-xl8h62
spec:
  templates:
    - name: hello-hello-hello
      inputs: {}
      outputs: {}
      metadata: {}
      steps:
        - - name: hello1
            template: whalesay
            arguments:
              parameters:
                - name: message
                  value: hello1
        - - name: hello2a
            template: whalesay2
            arguments:
              parameters:
                - name: message
                  value: hello2a
          - name: hello2b
            template: whalesay
            arguments:
              parameters:
                - name: message
                  value: hello2b
    - name: whalesay
      inputs:
        parameters:
          - name: message
      outputs: {}
      metadata: {}
      container:
        name: ''
        image: docker/whalesay
        command:
          - cowsay
        args:
          - '{{pod.name}}'
        resources: {}
    - name: whalesay2
      inputs: {}
      outputs: {}
      metadata: {}
      container:
        name: ''
        image: 'docker/whalesay:latest'
        command:
          - cowsay
        args:
          - '{{pod.name}}'
        resources: {}
      podSpecPatch: >-
        {"containers":[{"name":"main", "resources":{"limits":{"cpu":
        "{{workflow.parameters.cpu-limit}}" }}}]}
  entrypoint: hello-hello-hello
  arguments:
    parameters:
      - name: cpu-limit
        value: 100m
  ttlStrategy:
    secondsAfterCompletion: 600
  activeDeadlineSeconds: 300
  podSpecPatch: |
    terminationGracePeriodSeconds: 3


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@tczhao tczhao changed the title In argo 3.2, pod.name resolves to incorrect name when using specpatch or retry with podname v2, pod.name resolves to incorrect name when using specpatch or retry Oct 21, 2021
@alexec alexec added this to To do in Run The Business (incl. bugs) via automation Oct 21, 2021
@alexec alexec removed the triage label Oct 21, 2021
alexec pushed a commit that referenced this issue Oct 21, 2021
…ixes #7007 (#7008)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@alexec alexec moved this from To do to Done in Run The Business (incl. bugs) Oct 21, 2021
SunSparc pushed a commit to SunSparc/argo-workflows that referenced this issue Oct 22, 2021
…ixes argoproj#7007 (argoproj#7008)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: Jonathan Duncan <jonathan@nacnud.com>
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this issue Oct 24, 2021
…ixes argoproj#7007 (argoproj#7008)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@sarabala1979 sarabala1979 mentioned this issue Oct 26, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this issue Nov 4, 2021
25 tasks
alexec pushed a commit that referenced this issue Nov 17, 2021
…ixes #7007 (#7008)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@sarabala1979 sarabala1979 mentioned this issue Dec 15, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants