Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey TestDoNotCreatePodsUnderStopBehavior on docker #7040

Closed
Tracked by #7133
alexec opened this issue Oct 22, 2021 · 0 comments · Fixed by #7048
Closed
Tracked by #7133

Fix flakey TestDoNotCreatePodsUnderStopBehavior on docker #7040

alexec opened this issue Oct 22, 2021 · 0 comments · Fixed by #7048
Labels

Comments

@alexec
Copy link
Contributor

alexec commented Oct 22, 2021

=== RUN   TestSignalsSuite/TestDoNotCreatePodsUnderStopBehavior
323
Submitting workflow  stop-terminate-
324
Waiting 1m0s for workflow metadata.name=stop-terminate-bgtq6
325
 ? stop-terminate-bgtq6 Workflow 0s      
326

327
 ● stop-terminate-bgtq6   Workflow  0s      
328
 └ ◷ A                    Pod       0s      
329
 └ ● stop-terminate-bgtq6 Steps     0s      
330
 └ ● [0]                  StepGroup 0s      
331

332
 ● stop-terminate-bgtq6   Workflow  0s      
333
 └ ◷ A                    Pod       0s      ContainerCreating
334
 └ ● stop-terminate-bgtq6 Steps     0s      
335
 └ ● [0]                  StepGroup 0s      
336

337
 ● stop-terminate-bgtq6   Workflow  0s      
338
 └ ● stop-terminate-bgtq6 Steps     0s      
339
 └ ● [0]                  StepGroup 0s      
340
 └ ● A                    Pod       0s      
341

342
Condition "to have running pod" met after 1s
343
../../dist/argo -n argo stop @latest
344
workflow stop-terminate-bgtq6 stopped
345

346
Waiting 1m40s for workflow metadata.name=stop-terminate-bgtq6
347
 ● stop-terminate-bgtq6   Workflow  0s      
348
 └ ● [0]                  StepGroup 0s      
349
 └ ● A                    Pod       0s      
350
 └ ● stop-terminate-bgtq6 Steps     0s      
351

352
    signals_test.go:98: timeout after 1m40s waiting for condition
353
Checking expectation stop-terminate-bgtq6
354
stop-terminate-bgtq6 : Running 
355
    signals_test.go:101: 
356
        	Error Trace:	signals_test.go:101
357
        	            				then.go:66
358
        	            				then.go:41
359
        	            				signals_test.go:100
360
        	Error:      	Not equal: 
361
        	            	expected: "Failed"
362
        	            	actual  : "Running"
363
        	            	
364
        	            	Diff:
365
        	            	--- Expected
366
        	            	+++ Actual
367
        	            	@@ -1,2 +1,2 @@
368
        	            	-(v1alpha1.WorkflowPhase) (len=6) "Failed"
369
        	            	+(v1alpha1.WorkflowPhase) (len=7) "Running"
370
        	            	 
371
        	Test:       	TestSignalsSuite/TestDoNotCreatePodsUnderStopBehavior
372
    signals_test.go:104: 
373
        	Error Trace:	signals_test.go:104
374
        	            				then.go:66
375
        	            				then.go:41
376
        	            				signals_test.go:100
377
        	Error:      	Not equal: 
378
        	            	expected: "Failed"
379
        	            	actual  : "Running"
380
        	            	
381
        	            	Diff:
382
        	            	--- Expected
383
        	            	+++ Actual
384
        	            	@@ -1,2 +1,2 @@
385
        	            	-(v1alpha1.NodePhase) (len=6) "Failed"
386
        	            	+(v1alpha1.NodePhase) (len=7) "Running"
387
        	            	 
388
        	Test:       	TestSignalsSuite/TestDoNotCreatePodsUnderStopBehavior

https://github.com/argoproj/argo-workflows/actions/workflows/ci-build.yaml?query=branch%3Amaster

@alexec alexec changed the title Fix TestDoNotCreatePodsUnderStopBehavior or docker Fix flakey TestDoNotCreatePodsUnderStopBehavior or docker Oct 22, 2021
@alexec alexec changed the title Fix flakey TestDoNotCreatePodsUnderStopBehavior or docker Fix flakey TestDoNotCreatePodsUnderStopBehavior on docker Oct 24, 2021
@alexec alexec removed the triage label Oct 24, 2021
alexec added a commit to alexec/argo-workflows that referenced this issue Oct 24, 2021
…cutor. Fixes argoproj#7040

Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec added a commit that referenced this issue Oct 24, 2021
…cutor. Fixes #7040 (#7048)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this issue Oct 26, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this issue Nov 4, 2021
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant