Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod "START TIME"/ "END TIME" popup shows time in UTC instead of local timezone #7488

Closed
oleg-borodai opened this issue Jan 3, 2022 · 6 comments · Fixed by #7694
Closed
Labels
good first issue Good for newcomers type/feature Feature request

Comments

@oleg-borodai
Copy link
Contributor

oleg-borodai commented Jan 3, 2022

Summary

Pod START TIME popup shows time in UTC which doesn't match with actual value shown relatively to current moment(see screenshot). I would expect the popup to show time in my local timezone.

argo v3.2.6

Diagnostics

argo submit -n argo --watch https://raw.githubusercontent.com/argoproj/argo-workflows/master/examples/coinflip-recursive.yaml

Pasted Graphic 1

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@sarabala1979
Copy link
Member

@oleg-borodai It is a good enhancement. it is really challenging to display the time format.
Would you like to submit the PR for this enhancement?

@oleg-borodai
Copy link
Contributor Author

Unfortunately I have no idea about React. Probably with some guidance where to look into but I am not sure

@akpsan
Copy link

akpsan commented Jan 4, 2022

Hi I would like to work on this issue. If someone can point me in the right direction towards the basic documentation of the application and steps to reproduce. Thanks!

@sarabala1979
Copy link
Member

@akpsan Good and welcome. I will help with this. Please setup local env https://github.com/argoproj/argo-workflows/blob/master/docs/CONTRIBUTING.md

@lstolcman
Copy link
Contributor

I would expect the popup to show time in my local timezone.

Our team is located in different timezones, and definitely, we would not expect to have local time shown. Having common UTC is a great value for us.

Could you re-spec the proposed change to include UTC too?

@oleg-borodai
Copy link
Contributor Author

I would expect the popup to show time in my local timezone.

Our team is located in different timezones, and definitely, we would not expect to have local time shown. Having common UTC is a great value for us.

Could you re-spec the proposed change to include UTC too?

Probably having two lines in this popup could be a nice solution? I mean something of this format for the popup on the screenshot:
"2022-01-03T17:54:55
2022-01-03T16:54:55Z"

tinoschroeter added a commit to tinoschroeter/argo-workflows that referenced this issue Jan 29, 2022
… timezone Fixes argoproj#7488

Signed-off-by: Tino Schroter <tino.schroeter@gmail.com>
alexec pushed a commit that referenced this issue Jan 31, 2022
… timezone Fixes #7488 (#7694)

Signed-off-by: Tino Schroter <tino.schroeter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type/feature Feature request
Projects
None yet
4 participants