Argo CLI support for custom request headers

[tatodorov]

Summary

Add support for setting custom HTTP headers to argo CLI, similar to argocd -H, --header.

Use Cases

When Argo Workflows is configured behind IAP proxy like Cloudflare Access, we need to set a custom header with key cf-access-token and the actual token as a value.
Otherwise, when we execute argo list, we face the following error:

FATA[2022-02-23T22:38:56.530Z] invalid character '<' looking for beginning of value

This is already implemented in argocd CLI.
As an example, you can see issue #7036.

---

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

[alexec]

I'm assuming you're using ARGO_HTTP1=true.

We would need to pass the header here:

argo-workflows/pkg/apiclient/http1/facade.go

Line 60 in 6076524

req.Header.Set("Authorization", h.authorization)

It would get the header values from here:

argo-workflows/pkg/apiclient/argo-server-opts.go

Line 7 in 6076524

type ArgoServerOpts struct {

Which would be set here:

argo-workflows/cmd/argo/commands/client/conn.go

Line 48 in 6076524

cmd.PersistentFlags().BoolVar(&argoServerOpts.HTTP1, "argo-http1", os.Getenv("ARGO_HTTP1") == "true", "If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable.")

Would you like to submit a PR?

[tatodorov]

Would you like to submit a PR?

Yes, I will be working on a PR.