temaplateDefaults: container/script: image does nothing

[Maciej-Zwolinski]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

I wanted to set default image to use in script or container sections in templates using templateDefault feature on workflow(template). Instead of setting the default value I received an error message:

Internal Server Error: templates.default-workflow-template-poc.tasks.step-one templates.step-one.script.image may not be empty

There is no mention in docs of this field being prohibited.

Version

v3.3.9

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: default-workflow-template-poc
spec:
  entrypoint: mian-poc
  templateDefaults:
    script:
      image: my-private-repo/my_image:latest

  templates:
  - name: main-poc
    dag:
      tasks:
      - name: step-one
        template: step-one


  - name: step-one
    script:
      #image: my-private-repo/my_image:latest # <- commented out
      command: ["bash"]
      source: |
        set -euo pipefail
        echo "$PWD"

Logs from the workflow controller

n/a

Logs from in your workflow's wait container

n/a

[Maciej-Zwolinski]

The workaround is to supply parameter with default value for an image and reference it via workflow.parameters.image-name, but still, it does not solve the code replication issue.

[terrytangyuan]

This seems like a bug. Would anyone like to submit a PR to fix it?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

[jakemiller649]

Is there a list of fields that can/cannot be used with templateDefaults?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

[RoryDoherty]

Also running into this on version v3.4.3, could we remove the stale label
I'd also like to be able to template out the command field as well

[RoryDoherty]

This seems like a bug. Would anyone like to submit a PR to fix it?

@terrytangyuan I have opened a PR with a fix for this
#10784