Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set wf.spec.affinity.nodeAffinity, but agent pod has no nodeAffinity #9704

Closed
3 tasks done
chenyangxueHDU opened this issue Sep 28, 2022 · 4 comments · Fixed by #9771
Closed
3 tasks done

Set wf.spec.affinity.nodeAffinity, but agent pod has no nodeAffinity #9704

chenyangxueHDU opened this issue Sep 28, 2022 · 4 comments · Fixed by #9771
Labels
good first issue Good for newcomers P3 Low priority type/bug

Comments

@chenyangxueHDU
Copy link
Contributor

chenyangxueHDU commented Sep 28, 2022

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

Set wf.spec.affinity.nodeAffinity, but agent pod has no nodeAffinity. I expect to agent pod has the same affinity

Version

v3.3.9

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: hobot-dag-731187
spec:
  affinity:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
        - matchExpressions:
          - key: argo-dag
            operator: In
            values:
            - "true"
apiVersion: v1
kind: Pod
metadata:
  name: hobot-dag-731187-1340600742-agent
  namespace: argo
  ownerReferences:
  - apiVersion: argoproj.io/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: Workflow
    name: hobot-dag-731187
    uid: a936dc85-2e54-44fb-ba47-820b75081ade
spec:

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

@terrytangyuan
Copy link
Member

Currently, the agent pod spec is hard-coded and you won't be able to customize it.

@chenyangxueHDU
Copy link
Contributor Author

Currently, the agent pod spec is hard-coded and you won't be able to customize it.

Any plans for customizing the agent pod?

@terrytangyuan
Copy link
Member

terrytangyuan commented Sep 29, 2022

We could consider treating it similarly to other pods and allowing customization. Do you want to look into that?

@chenyangxueHDU
Copy link
Contributor Author

We could consider treating it similarly to other pods and allowing customization. Do you want to look into that?

ok

@sarabala1979 sarabala1979 added P3 Low priority good first issue Good for newcomers labels Oct 3, 2022
chenyangxueHDU pushed a commit to chenyangxueHDU/argo that referenced this issue Oct 8, 2022
chenyangxueHDU pushed a commit to chenyangxueHDU/argo that referenced this issue Oct 8, 2022
alexec pushed a commit that referenced this issue Oct 10, 2022
#9704 (#9771)

Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>

Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>
Co-authored-by: yangxue.chen <chenyangxuehdu@126.com>
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
argoproj#9704 (argoproj#9771)

Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>

Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>
Co-authored-by: yangxue.chen <chenyangxuehdu@126.com>
Signed-off-by: juchao <juchao@coscene.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P3 Low priority type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants