Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message field to lastRetry for conditional retries #9937

Closed
pjo256 opened this issue Nov 1, 2022 · 2 comments · Fixed by #10987
Closed

Add message field to lastRetry for conditional retries #9937

pjo256 opened this issue Nov 1, 2022 · 2 comments · Fixed by #10987
Labels
area/retryStrategy Template-level retryStrategy area/templating Templating with `{{...}}` type/feature Feature request

Comments

@pjo256
Copy link

pjo256 commented Nov 1, 2022 •
edited by agilgur5
Loading

Summary

In https://argoproj.github.io/argo-workflows/retries/#conditional-retries, lastRetry cannot access workflow error/failure messages such as Pod was terminated due to imminent node shutdown. This request is for adding a message on lastRetry containing this error message.

Use Cases

In #9880, we captured preemptions by setting OnTransientError and TRANSIENT_ERROR_PATTERN. However, we would also like to retry OnError. Using conditional retries, we cannot do both since lastRetry does not include a message field - e.g.

    retryStrategy:
        limit: "3"
        expression: "lastRetry.status == 'Error' || lastRetry.message.contains('imminent node shutdown')"

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@pjo256 pjo256 added the type/feature Feature request label Nov 1, 2022
@aarushisoni
Copy link

HI! I would like to work on this issue.

@terrytangyuan
Copy link
Member

Please go ahead and submit a PR if you'd like to contribute.

Joibel added a commit to Joibel/argo-workflows that referenced this issue Apr 26, 2023
@Joibel
feat: Add lastRetry.message
66db1ef 
As requested in argoproj#9937 add a message field to lastRetry to allow fine
grained control of retries.

Closes argoproj#9937

Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel added a commit to Joibel/argo-workflows that referenced this issue Apr 26, 2023
@Joibel
feat: Add lastRetry.message
d17513f 
As requested in argoproj#9937 add a message field to lastRetry to allow fine
grained control of retries.

Closes argoproj#9937

Signed-off-by: Alan Clucas <alan@clucas.org>
@Joibel Joibel mentioned this issue Apr 26, 2023
Merged
@agilgur5 agilgur5 added area/templating Templating with `{{...}}` area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries area/retryStrategy Template-level retryStrategy and removed area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries labels Apr 24, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/retryStrategy Template-level retryStrategy area/templating Templating with `{{...}}` type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add lastRetry.message Joibel/argo-workflows
4 participants
@pjo256 @terrytangyuan @agilgur5 @aarushisoni