Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workflow operation error. Fixes #10285 #10886

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

yeicandoit
Copy link
Contributor

Say why you made your changes.
fix issue that stop/termante workflow then retry meet error: Workflow operation error
#10285

Say what changes you made.
Update taskresult.go, when does not get node by node id, do not return the empty node

Say how you tested your changes.
I merge this change to v3.3.10, retry as described in issue #10285, this issue does not appear

fix issue that stop/termante workflow then retry meet error: Workflow operation error <br>
argoproj#10285

Signed-off-by: yeicandoit <410342333@qq.com>
@Sancerio
Copy link

We observed the same issue when we specify retryPolicy in all our workflows. The patch actually fixes the issue 👍

@terrytangyuan terrytangyuan changed the title Update taskresult.go fix: Workflow operation error. Fixes #10285 Apr 17, 2023
@terrytangyuan terrytangyuan merged commit 8766e7a into argoproj:master Apr 17, 2023
21 checks passed
terrytangyuan pushed a commit that referenced this pull request May 25, 2023
Signed-off-by: yeicandoit <410342333@qq.com>
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
Signed-off-by: yeicandoit <410342333@qq.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants