fix: Generate useful error message when no expression on hook #10919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not yet, the validator isn't quite done. |
Joibel
force-pushed
the
hook-expressions
branch
3 times, most recently
from
7de2e80
to
cb27c36
Compare
The error message for a missing or empty expression was `unable to evaluate expression '': unexpected token EOF (1:1)`. This changes it to a more useful `Expression required for hook <hook path>`. Also attempt to validate to prevent this problem upfront. Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
force-pushed
the
hook-expressions
branch
from
cb27c36
to
837ce52
Compare
| @@ -18,12 +19,15 @@ func (woc *wfOperationCtx) executeWfLifeCycleHook(ctx context.Context, tmplCtx * | |||
| if hookName == wfv1.ExitLifecycleEvent { | |||
| continue | |||
| } | |||
| hookNodeName := generateLifeHookNodeName(woc.wf.ObjectMeta.Name, string(hookName)) | |||
There was a problem hiding this comment.
This is not needed until inside the execute block?
There was a problem hiding this comment.
I use it on new line 24, two lines below this one as part of the error message.
terrytangyuan
approved these changes
May 1, 2023
44 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
May 25, 2023
Signed-off-by: Alan Clucas <alan@clucas.org>
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
…oj#10919) Signed-off-by: Alan Clucas <alan@clucas.org>
6 tasks
6 tasks
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…oj#10919) Signed-off-by: Alan Clucas <alan@clucas.org> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message for a missing or empty expression was
unable to evaluate expression '': unexpected token EOF (1:1). This changes it to a more usefulExpression required for hook <hook path>.Also attempt to validate to prevent this problem upfront.
Fixes #10910