fix: unable to connect cluster when AutomountServiceAccountToken is disabled. Fixes #10937 #10945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isabled Signed-off-by: Max Xu <xuhuan@live.cn>
|
@terrytangyuan PTAL, thanks! |
There was a problem hiding this comment.
Thanks. Could you add a test in https://github.com/argoproj/argo-workflows/tree/master/test/e2e?
Signed-off-by: Max Xu <xuhuan@live.cn>
Signed-off-by: Max Xu <xuhuan@live.cn>
@terrytangyuan Added two e2e tests, PTAL |
|
Test failure is related to your new test |
For K8s 1.24+, KSA won't create token secret automatically. Signed-off-by: Max Xu <xuhuan@live.cn>
Fixed by adding Secret/argo.service-account-token. Now all CI passed. It's due to the KSA token secret issue of K8s 1.24+, the |
alexec
approved these changes
Apr 24, 2023
terrytangyuan
approved these changes
Apr 24, 2023
44 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
May 25, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
4 tasks
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…isabled. Fixes argoproj#10937 (argoproj#10945) Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10937