Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade Go to v1.20. Fixes #11023 #11027

Merged
merged 7 commits into from
May 4, 2023

Conversation

terrytangyuan
Copy link
Member

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan enabled auto-merge (squash) May 3, 2023 14:25
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@blkperl blkperl added type/security Security related type/dependencies PRs and issues specific to updating dependencies and removed type/dependencies PRs and issues specific to updating dependencies labels May 3, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@@ -61,7 +61,8 @@ issues:
exclude:
# We are leaving io/ioutil for now to make backports easier
# https://github.com/argoproj/argo-workflows/pull/6964#issuecomment-946827019
- "SA1019: \"io/ioutil\" has been deprecated since Go 1.16"
- "SA1019: \"io/ioutil\" has been deprecated since Go 1.19"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delaying changes in #10972

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan merged commit a5581f8 into argoproj:master May 4, 2023
23 checks passed
@terrytangyuan terrytangyuan deleted the fix-go branch May 4, 2023 11:02
terrytangyuan added a commit that referenced this pull request May 25, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/build Build or GithubAction/CI issues labels Aug 28, 2023
@agilgur5 agilgur5 mentioned this pull request Aug 28, 2023
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/security Security related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants