fix: allow azure blobs to not exist when deleting #11070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workflow/artifacts/azure/azure.go
Outdated
| blobClient, err := containerClient.NewBlobClient(blobName) | ||
| if err != nil { | ||
| return fmt.Errorf("unable to create Azure Blob client for %s: %s", blobName, err) | ||
| } | ||
|
|
||
| _, err = blobClient.Delete(context.TODO(), nil) | ||
| if err != nil { | ||
| return fmt.Errorf("unable to delete Azure Blob %s: %s", blobName, err) | ||
| if allowNonExistent && IsAzureError(err, azblob.StorageErrorCodeBlobNotFound) { | ||
| log.Debugf("blob to delete '%s' does not exist (anymore): %s", blobName, err) |
Signed-off-by: Roel Arents <roel.arents@kadaster.nl>
roelarents
force-pushed
the
allow-azure-artifact-delete-nonexistent
branch
from
2467884
to
958c6ff
Compare
Signed-off-by: Dirc <e.e.cornet@gmail.com>
fix fix: allow azure blobs to not exist when deleting
|
Hi @terrytangyuan, I have tested the change and added a small fix. This fixes the bug for @roelarents and me. |
44 tasks
terrytangyuan
added a commit
that referenced
this pull request
May 25, 2023
Signed-off-by: Roel Arents <roel.arents@kadaster.nl> Signed-off-by: Dirc <e.e.cornet@gmail.com> Co-authored-by: Dirc <e.e.cornet@gmail.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
Signed-off-by: Roel Arents <roel.arents@kadaster.nl> Signed-off-by: Dirc <e.e.cornet@gmail.com> Co-authored-by: Dirc <e.e.cornet@gmail.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Roel Arents <roel.arents@kadaster.nl> Signed-off-by: Dirc <e.e.cornet@gmail.com> Co-authored-by: Dirc <e.e.cornet@gmail.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The docs say about artifact garbage collection:
However it is considered a failure at the moment. (At least for azure blobs.)
Modifications
Changed the azure implementation of the
ArtifactDriverto swallowStorageErrorCodeBlobNotFounderrors from the azure client whenDeleteing an artifact.Verification
I didn't test it yet.