fix: Parameter overwritten does not work when resubmitting archived workflow (#11086) #11087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toyamagu-2021
force-pushed
the
fix-resubmit-archive
branch
from
75bbbd9
to
a5c149f
Compare
|
@juliev0 can you take quick look? |
…orkflow. (argoproj#11086) Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
toyamagu-2021
force-pushed
the
fix-resubmit-archive
branch
from
a5c149f
to
868fd57
Compare
LGTM, but I think @terrytangyuan will be a better judge since he worked on this code. |
sarabala1979
approved these changes
May 15, 2023
Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
auto-merge was automatically disabled
May 15, 2023 12:51
Head branch was pushed to by a user without write access
toyamagu-2021
force-pushed
the
fix-resubmit-archive
branch
from
52fb5f3
to
137aa32
Compare
terrytangyuan
approved these changes
May 15, 2023
44 tasks
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
…orkflow (argoproj#11086) (argoproj#11087) Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
5 tasks
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…orkflow (argoproj#11086) (argoproj#11087) Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #11086
Modifications
req.ParameterstoFormulateResubmitWorkflowVerification
argo submit -n argo --watch https://raw.githubusercontent.com/argoproj/argo-workflows/master/examples/arguments-parameters.yamlargo archive resubmit ${uid}->message: hello world(expected)argo archive resubmit ${uid} --parameter message=test->message: test(expected)