Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Datepicker Style Malfunction Issue. Fixes #11476 #11480

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

zel0rd
Copy link
Contributor

@zel0rd zel0rd commented Jul 29, 2023

Fixes #11476

Motivation

The date filter is a crucial element when viewing the list of workflows. However, when clicking on the date-picker to change the date, the styles get messed up, resulting in a UI state where the filter functionality cannot be used properly. Moreover, the close button overlaps with the selected date, making it difficult to select the desired date.

Modifications

This issue is more related to layout and styles rather than a major functional problem. Therefore, we plan to make the following two modifications:

  1. Move the close button to the right so that it doesn't overlap with the date-picker.
  2. Adjust the styles of the date-picker using the calendar to ensure proper functionality.
스크린샷 2023-07-29 오후 7 22 32 KakaoTalk_20230729_153542342

Verification

Signed-off-by: zel0rd <zelord.kwoun@gmail.com>
@terrytangyuan terrytangyuan marked this pull request as ready for review August 1, 2023 00:31
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@terrytangyuan terrytangyuan merged commit ce9e50c into argoproj:master Aug 1, 2023
24 checks passed
terrytangyuan pushed a commit that referenced this pull request Aug 11, 2023
Signed-off-by: zel0rd <zelord.kwoun@gmail.com>
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
…oj#11480)

Signed-off-by: zel0rd <zelord.kwoun@gmail.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Datepicker Style Malfunction Issue
3 participants