Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade monaco-editor to 0.30 #11593

Merged
merged 1 commit into from
Aug 23, 2023

Commits on Aug 16, 2023

  1. deps(ui): upgrade monaco-editor to 0.30

    - 0.30 requires `monaco-editor-webpack-plugin` 6, per the [version matrix](https://github.com/microsoft/monaco-editor/tree/v0.41.0/webpack-plugin#version-matrix)
      - [0.29.0](https://github.com/microsoft/monaco-editor/blob/v0.41.0/CHANGELOG.md#0290-08102021) had a breaking change to `renderIndentGuides`; converted to the new option
        - `true` might not be necessary as it's the default, but `guides` is empty by default, so not 100% sure -- left it in for now to ensure the behavior remains the same after the upgrade
    
    - 0.30 is the latest version I could upgrade to without requiring significant build changes
      - 0.31+ uses newer JS syntax per the [breaking changes](https://github.com/microsoft/monaco-editor/blob/v0.41.0/CHANGELOG.md#0310-10122021)
        - Per https://stackoverflow.com/a/70622999/3431180, this requires an updated parser, otherwise the Webpack build was getting similar errors as in the SO question
          - tried to remove `monaco-editor` from the `babel-loader` `exclude` to remedy this, but then the build would crash due to out-of-memory (OOM) heap allocation errors
            - as a result, only upgraded to 0.30 for now, can upgrade to latest once the build system is upgraded
    
    Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    agilgur5 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    0f83aa8 View commit details
    Browse the repository at this point in the history