docs(cli): a stopped workflow cannot be resumed #11624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the CLI had incorrectly stated that `argo resume` could be used on a stopped workflow - remove that statement and specify that `resume` and `suspend` are opposites (and unrelated to `stop` / `terminate`) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
3 tasks
|
Ack, unit tests failed on a 429 rate limit error 😕 Will need to retry those |
5 tasks
caelan-io
approved these changes
Aug 24, 2023
terrytangyuan
approved these changes
Aug 24, 2023
terrytangyuan
changed the title
|
@terrytangyuan could you retry the unit tests CI? It hit a rate limit per above |
|
@terrytangyuan just following up on this one that needs a retry |
|
done |
terrytangyuan
pushed a commit
that referenced
this pull request
Sep 5, 2023
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11511
Motivation
The CLI had incorrectly stated that
argo resumecould be used on a stopped workflow, resulting in confusion for some users, such as in #11511Modifications
argo resumeresumeandsuspendare opposites (and therefore unrelated tostop/terminate)Verification
make codegenpassesBehavior Verification
To make sure that
argo resumedoes not affect stopped workflows, I looked through the source code:stopandterminateare two "shutdown strategies" with minor differencesspec.shutdownby the Server. then the operator and exec controller determine how to handle it (i.e. whether to run exit handlers or not).suspendandresumeare marked viaspec.suspend, which is an unrelated flag.As I had originally thought,
stopandresumeare unrelated operations. Not sure if there were related at some point in the past though.Notes for Reviewers
I wrote this as a "fix" commit so that it can be added as a patch to the CLI (and make it into any cherry-picks), but could make it a "docs" commit instead