Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ui): fix monaco-editor font path #11655

Merged
merged 1 commit into from
Aug 23, 2023

Commits on Aug 23, 2023

  1. fix(ui): update monaco-editor font path

    - the path appears to have changed in newer versions of Monaco
      - but builds seem to have still passed in efb1181
      - it then failed in aac4f89, likely because the updated `CopyWebpackPlugin` now actually errors out on a missing file
      - this `from` path is now equivalent to [Argo CD's config](https://github.com/argoproj/argo-cd/blob/24c080b5cbea6e3af547868e540caf553920dc73/ui/src/app/webpack.config.js#L89C28-L89C94)
    
    Verification:
    - from `argo-workflows/ui/`
      - ```sh
        ❯ ls node_modules/monaco-editor/min/vs/base/browser/ui/codicons/codicon/codicon.ttf
        node_modules/monaco-editor/min/vs/base/browser/ui/codicons/codicon/codicon.ttf
        ```
      - also there is no `codiconLabel` directory anymore
    - build now passes
    
    Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    agilgur5 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3d5a443 View commit details
    Browse the repository at this point in the history