-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update to use markdownlint compatible changelog #11733
build: Update to use markdownlint compatible changelog #11733
Conversation
MD024: | ||
siblings_only: true | ||
MD034: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this break the links to the existing headers, e.g. https://github.com/argoproj/argo-workflows/blob/master/CHANGELOG.md#v350-rc1-2023-08-15?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the concerns, but the anchor to the header seems to work well: https://github.com/argoproj/argo-workflows/blob/428ddb118e826d322527a7a5c59e80418401ae1f/CHANGELOG.md#v350-rc1-2023-08-15
MD034
is a lint rule about using url in markdown file. (ex. https://example.com
in *.md
will produce warning)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to configure these inline for the whole file rather than globally.
As in, using:
<!-- markdownlint-disable MD034 -->
<!-- markdownlint-configure-file { "MD024": { "siblings_only": true } } -->
Also some comments would be nice as to why these were disabled, as is convention and as the rest of the file does (otherwise, it's not clear why a rule is changed)
And uh.. I realized I've been looking at the wrong markdownlint this whole time 😭
that one doesn't support inline ignores but the one we are using actually does!
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove changes in this file? This will be auto-generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course! I force-pushed the latest commit. Thansk for the comment :D
Signed-off-by: sudosubin <sudosubin@gmail.com>
428ddb1
to
1b9d36c
Compare
Signed-off-by: sudosubin <sudosubin@gmail.com>
Resolved markdownlint errors for
CHANGELOG.md
.Motivation
Argo Workflows project has markdownlint configuration, but many markdown documents does not respect the lint rules. (I'm currently working on markdownlint.)
Modifications
I also updated
./hack/changelog.sh
script.MD024
: https://github.com/DavidAnson/markdownlint/blob/main/doc/md024.mdMultiple headings with the same content
allows only sibling headingsMD034
: https://github.com/DavidAnson/markdownlint/blob/main/doc/md034.mdBare URL used
allowedVerification