fix(ui): merge WF List FTU Panel with New Version Modal #11742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Workflows being hidden behind a first-time user panel was confusing - reported in an issue with a few upvotes - personally, I did not even realize that panel specified a new default, it just seemed like another unnecessary FTU click when my cookies get cleared -- similar to the survey etc - Move the description of the new default instead to the New Version Modal - and specify in **bold** that there is a new default Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
terrytangyuan
approved these changes
Sep 15, 2023
terrytangyuan
pushed a commit
that referenced
this pull request
Oct 19, 2023
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10821
Technically a follow-up to #8596, which added this FTU Panel
Motivation
Modifications
Move the description of the new default instead to the New Version Modal
unrelated: simplify some syntax in this file using optional chaining (from investigating UI does not show all running workflows (it used to) / UI and
argo listdiffer (missing running workflows) #9696)Verification
/workflowsSee below screenshot with the New Version Modal as well as the Workflow List in the background:
Future Work
WorkflowListcould be optimized a bit. It's got a few internal functions that are purely static and could be moved out of the component as such. Left the diff pretty minimal in this PR thoughEDIT: Completed this in #11891