Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Modify CronWorkflowSpec, Status fields examples #11748

Conversation

newdeal123
Copy link

@newdeal123 newdeal123 commented Sep 5, 2023

Motivation

Docs examples that do not use cronworkflow are included in the CronWorkflowSpec, CronWorkflowStatus fields, causing confusion in finding the necessary data.

Modifications

Examples in the CronWorkflowSpec, CronWorkflowStatus field allow only examples using cronworkflow to find the necessary materials.

Verification

I submitted workflows by copy & paste.

Signed-off-by: Cade(서청운) <newdeal123@nate.com>
Signed-off-by: Cade(서청운) <newdeal123@nate.com>
@newdeal123 newdeal123 marked this pull request as ready for review September 5, 2023 11:44
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated file so you'd want to fix the docgen script.

@newdeal123 newdeal123 marked this pull request as draft September 5, 2023 12:26
@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label Sep 5, 2023
@agilgur5 agilgur5 added the problem/stale This has not had a response in some time label Sep 26, 2023
@agilgur5 agilgur5 added the problem/more information needed Not enough information has been provide to diagnose this issue. label Jan 17, 2024
@github-actions github-actions bot removed problem/stale This has not had a response in some time problem/more information needed Not enough information has been provide to diagnose this issue. labels Jan 18, 2024
@agilgur5 agilgur5 added the problem/more information needed Not enough information has been provide to diagnose this issue. label Feb 5, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity and needs further changes. It will be closed if no further activity occurs.

@github-actions github-actions bot added the problem/stale This has not had a response in some time label Feb 20, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

This PR has been closed due to inactivity and lack of changes. If you would like to still work on this PR, please address the review comments and re-open.

@github-actions github-actions bot closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs problem/more information needed Not enough information has been provide to diagnose this issue. problem/stale This has not had a response in some time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants