Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: reduce test & CI flakes with retries + longer waits & timeouts #11753

Merged
merged 5 commits into from
Sep 7, 2023
Merged

ci: reduce test & CI flakes with retries + longer waits & timeouts #11753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5d2975
fix(test): bump signals StopBehavior timeout due to flakes
agilgur5 Sep 6, 2023
fc0f9e6
fix(test): also bump agent `StatusCondition` wait
agilgur5 Sep 6, 2023
588c625
fix(test): bump `StopBehavior` again
agilgur5 Sep 6, 2023
ab65211
fix(codegen): use `curl --fail` to retry on bad status codes
agilgur5 Sep 6, 2023
4e38ed8
fix(ci): bump controller wait timeout
agilgur5 Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ jobs:
- run: make start PROFILE=${{matrix.profile}} AUTH_MODE=client STATIC_FILES=false LOG_LEVEL=info API=${{matrix.test == 'test-api' || matrix.test == 'test-cli' || matrix.test == 'test-java-sdk' || matrix.test == 'test-python-sdk'}} UI=false > /tmp/argo.log 2>&1 &
name: Start controller/API
- run: make wait API=${{matrix.test == 'test-api' || matrix.test == 'test-cli' || matrix.test == 'test-java-sdk' || matrix.test == 'test-python-sdk'}}
timeout-minutes: 4
timeout-minutes: 5
name: Wait for controller to be up
- name: Run tests ${{matrix.test}}
run: make ${{matrix.test}} E2E_SUITE_TIMEOUT=20m STATIC_FILES=false
Expand Down
4 changes: 2 additions & 2 deletions hack/recurl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ url=$2

if [ ! -f "$file" ]; then
# loop forever
while ! curl -L -o "$file" -- "$url" ;do
while ! curl -L --fail -o "$file" -- "$url" ; do
echo "sleeping before trying again"
sleep 10s
done
fi

chmod +x "$file"
chmod +x "$file"
2 changes: 1 addition & 1 deletion test/e2e/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ spec:
`).
When().
SubmitWorkflow().
WaitForWorkflow(time.Minute).
WaitForWorkflow(time.Minute + 5*time.Second).
Then().
ExpectWorkflow(func(t *testing.T, _ *metav1.ObjectMeta, status *wfv1.WorkflowStatus) {
assert.Equal(t, wfv1.WorkflowFailed, status.Phase)
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/signals_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func (s *SignalsSuite) TestStopBehavior() {
SubmitWorkflow().
WaitForWorkflow(fixtures.ToHaveRunningPod, killDuration).
ShutdownWorkflow(wfv1.ShutdownStrategyStop).
WaitForWorkflow(killDuration).
WaitForWorkflow(killDuration + 10*time.Second). // this one takes especially long in CI
Then().
ExpectWorkflow(func(t *testing.T, m *metav1.ObjectMeta, status *wfv1.WorkflowStatus) {
assert.Contains(t, []wfv1.WorkflowPhase{wfv1.WorkflowFailed, wfv1.WorkflowError}, status.Phase)
Expand Down