docs: modify demo image in intermediate-inputs.md #11755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahn Jiwan <synoti21@naver.com>
agilgur5
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Could you crop this image to not show your bookmarks, URL bar, tabs, etc?
There was a problem hiding this comment.
Okay, I'll crop it right now
There was a problem hiding this comment.
Oh my bad, I didn't realize the top bar is actually from the video itself, not a screenshot you made yourself.
Crop is still good to have though, thanks!
|
Similar to #11732 |
Signed-off-by: Ahn Jiwan <synoti21@naver.com>
Signed-off-by: Ahn Jiwan <synoti21@naver.com>
agilgur5
approved these changes
Sep 6, 2023
terrytangyuan
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In "Intermediate Parameters" page in argoproj.github.io, there are two clickable images that users cannot know that it can play demo videos.
Modifications
I replaced them with two images that have YouTube logo that users can easily know it's a playable demo video. I considered to replace with embed videos, but since another contributor changed to image with YouTube logo in other documents, I also changed in the same way for consistency.
Verification