fix(ui): handle undefined
dates in Workflows List filter
#11792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix for #9696
Motivation
undefined
with Datesundefined
always returnsfalse
Modifications
true
Verification
Can see in the below screenshot (in React DevTools) that
minStartedAt
was set toundefined
after I hit the "x" button on the date filter:Made sure that
undefined
did in fact act weirdly, and here's results from browser console REPL:Tested manually in the UI and made sure it works as expected