ci: also skip windows unit test runs based on diff #12034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- windows unit tests were merged shortly before my changes to skip tests were merged - c.f. 116cf6d, e058c44 - they are new, so they also need a conditional now - windows tests could potentially be optimized run on a smaller set of changed files - since I think they don't run all unit tests Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
terrytangyuan
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
needsand anifsection to thetests-windowsjob, same exact one as the one intestsVerification
no new logic here as this exact conditional is already used for the
testsjobFuture Work