fix: regression in memoization without outputs #12130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merge with argoproj#11451 reverted this, so this commit is just to reinstate that. The tests included in argoproj#11379 failed to catch this, I've raised argoproj#12129 for this, but in the interests of matching the documentation and kubecon next week I'm putting this PR in now. Fixes argoproj#12117 Signed-off-by: Alan Clucas <alan@clucas.org>
3 tasks
agilgur5
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Confirmed that there was a subtle accidental revert on this line due to the merge and that this change reinstates it
terrytangyuan
approved these changes
Nov 3, 2023
terrytangyuan
pushed a commit
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Alan Clucas <alan@clucas.org>
terrytangyuan
pushed a commit
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Alan Clucas <alan@clucas.org>
3 tasks
terrytangyuan
added a commit
that referenced
this pull request
Nov 15, 2023
This reverts commit c751e66.
Joibel
added a commit
to Joibel/argo-workflows
that referenced
this pull request
Nov 15, 2023
This is a partial revert of argoproj#12130 and fixes argoproj#12165 Offered as an alternative to a full revert. Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
added a commit
to Joibel/argo-workflows
that referenced
this pull request
Nov 15, 2023
This is a partial revert of argoproj#12130 and fixes argoproj#12165 Offered as an alternative to a full revert. Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
added a commit
to Joibel/argo-workflows
that referenced
this pull request
Nov 15, 2023
This is a partial revert of argoproj#12130 and fixes argoproj#12165 Offered as an alternative to a full revert Signed-off-by: Alan Clucas <alan@clucas.org>
terrytangyuan
added a commit
that referenced
this pull request
Nov 15, 2023
This reverts commit c751e66.
terrytangyuan
added a commit
that referenced
this pull request
Nov 15, 2023
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Alan Clucas <alan@clucas.org> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…#12130)" (argoproj#12201) Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11379 allowed memoization without outputs.
The merge with #11451 reverted this, so this commit is just to reinstate that.
The tests included in #11379 failed to catch this, I've raised #12129 to fix this, but in the interests of matching the documentation and with time limited and kubecon next week I'm putting this PR in now.
Fixes #12117