Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch to upstream go-git. Fixes CVE-2023-49569 #12515

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Conversation

terrytangyuan
Copy link
Member

This fixes a critical severity vulnerability https://www.cve.org/CVERecord?id=CVE-2023-49569. We cannot use the existing fork anymore. Security is always the highest priority.


✗ Critical severity vulnerability found in github.com/go-git/go-git/v5
  Description: Path Traversal
  Info: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMGOGITGOGITV5-6150754
  Introduced through: github.com/go-git/go-git/v5@5.4.7
  From: github.com/go-git/go-git/v5@5.4.7
  Fixed in: 5.11.0

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan added the prioritized-review For members of the Sustainability Effort label Jan 14, 2024
@terrytangyuan terrytangyuan enabled auto-merge (squash) January 14, 2024 01:48
@terrytangyuan terrytangyuan merged commit 2bdd7f3 into main Jan 14, 2024
27 checks passed
@terrytangyuan terrytangyuan deleted the fix-go-git branch January 14, 2024 02:09
@agilgur5 agilgur5 added type/security Security related type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Jan 14, 2024
@agilgur5 agilgur5 added the area/artifacts S3/GCP/OSS/Git/HDFS etc label Jan 14, 2024
@agilgur5
Copy link
Member

We cannot use the existing fork anymore. Security is always the highest priority.

It seems like we were planning on this anyway in #11483 and #11149, in particular since upstream go-git had become maintained again and Argo CD was using upstream as well. I wasn't involved then though, so I don't know the full context.

@agilgur5
Copy link
Member

agilgur5 commented Jan 14, 2024

This fixes a critical severity vulnerability https://www.cve.org/CVERecord?id=CVE-2023-49569.

For reference, the details:

Maliciously crafted Git server replies can lead to path traversal and RCE on go-git clients

So this only has impact if you have an untrusted Git server. For the principles of zero trust, this is definitely still very important to fix (especially as trusted Git servers can be hacked or supply chain attacked too), but most people will probably not be impacted by this as they use a trusted enterprise vendor

terrytangyuan added a commit that referenced this pull request Jan 14, 2024
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan added a commit that referenced this pull request Jan 14, 2024
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc go Pull requests that update Go dependencies prioritized-review For members of the Sustainability Effort type/dependencies PRs and issues specific to updating dependencies type/security Security related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants