fix: Patch taskset with subresources to delete completed node status. Fixes #11489 #12620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswxstw
force-pushed
the
fix-11489
branch
5 times, most recently
from
d921fda
to
4ab8e89
Compare
…ixes argoproj#11489 Signed-off-by: oninowang <oninowang@tencent.com>
agilgur5
added
area/controller
3 tasks
isubasinghe
reviewed
Feb 17, 2024
isubasinghe
reviewed
Feb 17, 2024
isubasinghe
approved these changes
Feb 18, 2024
isubasinghe
added a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 20, 2024
argoproj#12620) Signed-off-by: oninowang <oninowang@tencent.com> Co-authored-by: jswxstw <jswxstw@gmail.com> Co-authored-by: Isitha Subasinghe <isitha@pipekit.io>
isubasinghe
added a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
argoproj#12620) Signed-off-by: oninowang <oninowang@tencent.com> Co-authored-by: jswxstw <jswxstw@gmail.com> Co-authored-by: Isitha Subasinghe <isitha@pipekit.io>
isubasinghe
added a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
argoproj#12620) Signed-off-by: oninowang <oninowang@tencent.com> Co-authored-by: jswxstw <jswxstw@gmail.com> Co-authored-by: Isitha Subasinghe <isitha@pipekit.io> Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
isubasinghe
added a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
argoproj#12620) Signed-off-by: oninowang <oninowang@tencent.com> Co-authored-by: jswxstw <jswxstw@gmail.com> Co-authored-by: Isitha Subasinghe <isitha@pipekit.io>
4 tasks
6 tasks
agilgur5
changed the title
isubasinghe
added a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
argoproj#12620) Signed-off-by: oninowang <oninowang@tencent.com> Co-authored-by: jswxstw <jswxstw@gmail.com> Co-authored-by: Isitha Subasinghe <isitha@pipekit.io>
isubasinghe
added a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 7, 2024
argoproj#12620) Signed-off-by: oninowang <oninowang@tencent.com> Co-authored-by: jswxstw <jswxstw@gmail.com> Co-authored-by: Isitha Subasinghe <isitha@pipekit.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11489
Motivation
Workflow manual retrying does not work for Plugin, because completed node status in WorkflowTaskSet are not deleted successfully.
Modifications
Split the original WorkflowTaskSet patch into tasksPatch and nodesPatch, then patch the nodesPatch with
statussubresource.Verification
run locally
add e2e test