fix: controller option to not watch configmap #12622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Quadri <paolo.quadri@remote.com>
pquadri
force-pushed
the
fix/controller-option-to-not-watch-configmap
branch
from
f795d40
to
05e5c36
Compare
|
|
agilgur5
added
solution/workaround
|
not sure about the failed test, probably a flaky one but i can't retry the action :/ |
|
I gave it a retry. That was an Executor test, so sounds unrelated, but I'm not sure I've seen that specific test flake before (though some related tests have before |
be more specific on the env var Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
be more specific on the env var Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
agilgur5
approved these changes
Feb 8, 2024
This was referenced Feb 8, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Paolo Quadri <paolo.quadri@remote.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Paolo Quadri <paolo.quadri@remote.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Paolo Quadri <paolo.quadri@remote.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
3 tasks
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Mar 26, 2024
#### Motivation In order to reduce the Argo controller logs due to [this issue](argoproj/argo-workflows#11657), we can use [this workaround](argoproj/argo-workflows#12622) for now. #### Modification Using `WATCH_CONFIGMAPS=false` workaround implies upgrading Argo Workflows: - upgrade Argo Workflows to `3.5.5` - set `WATCH_CONFIGMAPS` to Argo Controller environment variable to `false` Non regression tested on a NonProd cluster. #### Checklist - [ ] Tests updated - [x] Docs updated - [x] Issue linked in Title
|
Hello, I try this workaround This increase our AWS CloudWatch costs.... we will add a filter on fluentbit to do not send this log... Any idea why the workaround doesnt works ? |
|
@xrafhue the os variable should be |
|
@tooptoop4 , after 2 days in all our clusters the logs are more generated. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11657
Original PR by @tooptoop4 here: #12400