Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade argoproj/pkg version #12651

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

csantanapr
Copy link
Member

@csantanapr csantanapr commented Feb 9, 2024

Fixes #12650

Motivation

Update aws-sdk version for EKS Pod Identity

Modifications

update go deps

Verification

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terrytangyuan terrytangyuan enabled auto-merge (squash) February 9, 2024 23:05
@terrytangyuan terrytangyuan merged commit 7d70fe2 into argoproj:main Feb 9, 2024
28 checks passed
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/artifacts S3/GCP/OSS/Git/HDFS etc labels Feb 9, 2024
@@ -47,15 +47,15 @@ require (
github.com/sirupsen/logrus v1.9.3
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/soheilhy/cmux v0.1.5
github.com/spf13/cobra v1.7.0
github.com/spf13/cobra v1.8.0
Copy link
Member

@agilgur5 agilgur5 Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cobra on this line and crypto on line 58 below seem to be unrelated changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was go tidy did ut

isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 27, 2024
Signed-off-by: Carlos Santana <carrlos@amazon.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 27, 2024
Signed-off-by: Carlos Santana <carrlos@amazon.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 27, 2024
Signed-off-by: Carlos Santana <carrlos@amazon.com>
@rafilkmp3
Copy link

Can someone confirm if it is included in release 3.5.7

@agilgur5
Copy link
Member

agilgur5 commented May 30, 2024

The answer is the same as the one to your previous question, #12949 (comment), for the exact same reasons.

You can also see all commits in the changelog as well as git history of the tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EKS Pod Identity to access AWS s3
4 participants