feat: Promote "Host" header if present. Fixes #12690 #12691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promotes any `Host` header to the `http.Request.Host` field. Relates to golang/go#29865 Signed-off-by: Phil Brown <pbrown2@atlassian.com>
|
What was your intent for this -- did you mean to modify the CLI? Because the It may make sense to limit this change to only the CLI if that was your intent |
|
@agilgur5 the intent was for the CLI. I didn't see anywhere else where this could possibly be done though. The request construction is completely opaque outside the Facade |
Trim whitespace from any detected "Host" header value Signed-off-by: Phil Brown <pbrown2@atlassian.com>
|
Unit test failure doesn't seem related and I cannot reproduce it locally. Counting files in |
|
FYI we're using my fork and it's working great for us. It would be fantastic if this could be incorporated into the official release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12690
Motivation
When communicating with a proxy or load balancer that does not do Host header rewriting, it may be required to override the default request Host header.
Go's HTTP request does not do this by default when passed a Host header value.
Modifications
Checks for any
Hostheader in the HTTPFacadeand promotes it to the requestHostfield if found.Verification
This is a very simple change and since there were no existing headers tests, it didn't seem necessary.