Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): show correct podGC message for deleteDelayDuration. Fixes: #12395 #12784

Merged
merged 5 commits into from
Mar 12, 2024
Merged

fix(ui): show correct podGC message for deleteDelayDuration. Fixes: #12395 #12784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d799994
fix: Incorrect message on UI when podGC is enabled with deleteDelayDu…
shuangkun Mar 12, 2024
890cff8
Update ui/src/app/workflows/components/workflow-logs-viewer/workflow-…
shuangkun Mar 12, 2024
899dec7
Update ui/src/app/workflows/components/workflow-logs-viewer/workflow-…
agilgur5 Mar 12, 2024
1216227
Update ui/src/app/workflows/components/workflow-logs-viewer/workflow-…
agilgur5 Mar 12, 2024
28229cd
Update ui/src/app/workflows/components/workflow-logs-viewer/workflow-…
agilgur5 Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,8 @@ export function WorkflowLogsViewer({workflow, nodeId, initialPodName, container,
)}
{execSpec(workflow).podGC && (
<>
<WarningIcon /> Your pod GC settings will delete pods and their logs immediately on completion.
<WarningIcon /> Your pod GC settings will delete pods and their logs{' '}
{execSpec(workflow).podGC.deleteDelayDuration ? `after ${execSpec(workflow).podGC.deleteDelayDuration}` : 'immediately'} on completion.
</>
)}{' '}
Logs may not appear for pods that are deleted.{' '}
Expand Down
1 change: 1 addition & 0 deletions ui/src/models/workflows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,7 @@ export interface WorkflowSpec {
*/
podGC?: {
strategy?: string;
deleteDelayDuration?: string;
};
/**
* SecurityContext holds pod-level security attributes and common container settings.
Expand Down