fix: Enable realtime metric gc after its workflow is completed. Fixes #12790 #12830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
suggested changes
Mar 21, 2024
agilgur5
added
area/metrics
area/gc
Joibel
suggested changes
Mar 25, 2024
…rgoproj#12790 Signed-off-by: oninowang <oninowang@tencent.com>
Joibel
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12790
Motivation
Realtime metrics may be cleaned up, even if the workflow is still running.
Modifications
Adding two boolean value:
realtimeandcompletein metric to indicate whether the metric is realtime type and whether it is completed.Enable realtime metric gc only after its workflow is completed.
Verification
local test and UT