refactor: remove unnecessary AddEventHandler error handling
#12917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in k8s 1.26+, the `informer.AddEventHandler` function can return an error - however, this error will only happen when the informer been stopped already (https://github.com/kubernetes/client-go/blob/46588f2726fa3e25b1704d6418190f424f95a990/tools/cache/shared_informer.go#L580) - in the `new*Informer` functions, we literally just created them, with `AddEventHandler` on the very next line, so this error is impossible in these cases - so ignore the error and remove some error handling code around that Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
blkperl
approved these changes
Apr 9, 2024
isubasinghe
approved these changes
Apr 11, 2024
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12847 (comment)
Motivation
informer.AddEventHandlerfunction can return an errornew*Informerfunctions, we literally just created them, withAddEventHandleron the very next line, so this error is impossible in these casesModifications
//nolint:errcheckdirectives with comments on errors that can be safely ignoredVerification
lint passes, all E2Es pass. checked the informer source code myself.