Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cli): add riscv64 support #12977

Merged
merged 1 commit into from
Apr 24, 2024
Merged

build(cli): add riscv64 support #12977

merged 1 commit into from
Apr 24, 2024

Conversation

mengzhuo
Copy link
Contributor

Motivation

As riscv growing popularity and being adopted by more projects
https://github.com/carlosedp/riscv-bringup

and commercial Cloud provider like Scaleway https://www.scaleway.com/en/news/scaleway-launches-its-risc-v-servers-in-the-cloud-a-world-first-and-a-firm-commitment-to-technological-independence/

It's possible to run argo workflow by riscv users.

Modifications

Adds riscv64 support

Verification

make dist/argo-linux-riscv64 && ./dist/argo-linux-riscv64

argo prints help verbose.

@mengzhuo mengzhuo changed the title all: add riscv64 support feat: add riscv64 support Apr 24, 2024
@Joibel
Copy link
Member

Joibel commented Apr 24, 2024

This will only support the CLI on riscV, but that's the only component we support on non amd64/arm64 for other less popular architectures.
It will not allow the workflow's kubernetes components to run on riscV.
Anyway, LGTM

@Joibel Joibel added the area/cli The `argo` CLI label Apr 24, 2024
@Joibel
Copy link
Member

Joibel commented Apr 24, 2024

@mengzhuo, you will need to sign your commits according to https://github.com/argoproj/argoproj/blob/main/community/CONTRIBUTING.md. You will need to rewrite this commit to make the DCO check pass.

Signed-off-by: Meng Zhuo <mengzhuo1203@gmail.com>
@agilgur5 agilgur5 changed the title feat: add riscv64 support feat(cli): add riscv64 support Apr 24, 2024
@agilgur5
Copy link
Member

This will only support the CLI on riscV, but that's the only component we support on non amd64/arm64 for other less popular architectures.

^This, see also #12067 for the rest

Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is existing precedent for CLI binaries, as Alan noted

@agilgur5 agilgur5 enabled auto-merge (squash) April 24, 2024 15:15
@agilgur5 agilgur5 added the area/build Build or GithubAction/CI issues label Apr 24, 2024
@agilgur5 agilgur5 merged commit 7c04653 into argoproj:main Apr 24, 2024
28 checks passed
@agilgur5 agilgur5 changed the title feat(cli): add riscv64 support build(cli): add riscv64 support Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues area/cli The `argo` CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants