Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove misleading logs from crdgen.sh #12989

Merged
merged 1 commit into from Apr 28, 2024
Merged

Conversation

terrytangyuan
Copy link
Member

The current logs are misleading which may look like both the minimal and full CRDs are applied to the cluster twice:

Patching ...
Creating ...

The PR makes it less confusing.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've never noticed this but yea the words "creating" and "patching" are k8s terms and so could definitely be misunderstood, so seems like a helpful change to me

@agilgur5 agilgur5 added the area/build Build or GithubAction/CI issues label Apr 28, 2024
@terrytangyuan terrytangyuan merged commit 2bea4ba into main Apr 28, 2024
15 checks passed
@terrytangyuan terrytangyuan deleted the terrytangyuan-patch-1 branch April 28, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants