ci: run E2E tests if Dockerfile changes
#13024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
changed the title
agilgur5
reviewed
May 8, 2024
agilgur5
changed the title
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
approved these changes
May 8, 2024
There was a problem hiding this comment.
LGTM, per above and #13023 (comment), Dockerfile is used to build images that are used in the E2E tests.
We may want to further add files that change the docker build context, same as #12006 "Future Work"
agilgur5
changed the title
Dockerfile changes
agilgur5
pushed a commit
that referenced
this pull request
May 27, 2024
Signed-off-by: Alan Clucas <alan@clucas.org> Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Anton Gilgur <agilgur5@gmail.com> (cherry picked from commit ebf4ef9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Dockerfile changes we should re-test most of the world