Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(faq): add note about pods patch error #13041

Merged
merged 1 commit into from
May 13, 2024

Conversation

agilgur5
Copy link
Member

Motivation

Modifications

Verification

make docs passes

Future Work

We may want to modify this or add to it in the next minor when #12976 lands. I would probably suggest adding a second error message similar to the "token not valid" error message above, which has old variants and new variants

- questions about `pods` `patch` errors are probably the most common questions we field on Slack & GH Issues + Discussions, especially by beginners
  - so I think this deserves a spot on the FAQ
  - users also often only see the error and miss the preceding log that this is a fallback when `workflowtaskresults` RBAC is not available
    - so they end up searching the `pod` `patch` error instead, which isn't written about in the docs -- hence this PR

- replace the previous note about "unknown (get pods)", which was removed in v3.3.1 in af26ff7
  - also remove the blog link as has dated RBAC and we shouldn't be linking to dated material when possible
    - I also left a comment on the blog post clarifying that it's dated: https://medium.com/@agilgur5/note-that-this-blog-post-is-from-oct-2020-cf4cb541915d

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
@agilgur5 agilgur5 added area/executor area/docs Incorrect, missing, or mistakes in docs labels May 12, 2024
@agilgur5 agilgur5 added this to the v3.5.x patches milestone May 12, 2024
@agilgur5 agilgur5 requested a review from Joibel May 12, 2024 23:37
@agilgur5 agilgur5 added the prioritized-review For members of the Sustainability Effort label May 13, 2024
@juliev0 juliev0 merged commit 0bfaea6 into argoproj:main May 13, 2024
17 checks passed
@agilgur5 agilgur5 deleted the docs-faq-pod-patch branch May 13, 2024 02:21
agilgur5 added a commit that referenced this pull request May 14, 2024
- fixed merge conflict with executors note which still exists in 3.5

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
(cherry picked from commit 0bfaea6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs area/executor prioritized-review For members of the Sustainability Effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants