fix: Remove overriding executionDeadline with maxDurationDeadline. Fixes #13044 #13049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13044
Motivation
I've noticed that the
maxDurationDeadline
calculation process is unusual and this value is overridingexecutionDeadline
.For example, with the following workflow, it waits for 120 seconds and exits with error code 10:
But, when the first attempt fails, the second node's container has a deadline within 1 minute, and it is killed by its wait container.
The latest Argo workflow follows this timeline (not exact times, for easier understanding):
Modifications
maxDuration
to firstChildNode's startTime.maxDurationDeadline
withlastChildNode
'sfinishedTime
.executionDeadline
was overridden bymaxDurationDeadline
.Verifications
I've tested with the above workflow, and it is working as expected.