refactor(ui): heavily simplify WorkflowCreator effect
#13094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduce nesting in this effect quite significantly with early returns - and remove an unnecessary `switch` statement (not sure if it had more than one `case` before?) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reduce tech debt, code complexity, etc
Modifications
switchstatementcasebefore? itgit blames back to feat(ui): Argo Events API and UI. Fixes #888 #4470 which moved the UI fromargo-uito this repo)Verification
No semantic changes, functionally equivalent.
Tested creating a Workflow in different ways and it worked fine.
Notes to Reviewers
The diff is much easier to read with the ignore whitespace setting