-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): clarify CronWorkflow startingDeadlineSeconds
. Fixes #12971
#13280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
area/docs
Incorrect, missing, or mistakes in docs
area/cron-workflows
labels
Jun 29, 2024
agilgur5
changed the title
fix: Clarify docs for CronWorkflow startingDeadlineSeconds. Fixes #12971
fix(docs): clarify CronWorkflow Jun 29, 2024
startingDeadlineSeconds
. Fixes #12971
agilgur5
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further simplifications & style changes below
…oproj#12971 Co-authored-by: Neile Havens <neilehavens@gmail.com> Signed-off-by: qingfeng777 <251098199@qq.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the clarification to the docs
agilgur5
pushed a commit
that referenced
this pull request
Jul 6, 2024
… (#13280) Signed-off-by: qingfeng777 <251098199@qq.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Neile Havens <neilehavens@gmail.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Anton Gilgur <agilgur5@gmail.com> (cherry picked from commit 9c5dd5b)
agilgur5
pushed a commit
that referenced
this pull request
Jul 6, 2024
… (#13280) Signed-off-by: qingfeng777 <251098199@qq.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Neile Havens <neilehavens@gmail.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Anton Gilgur <agilgur5@gmail.com> (cherry picked from commit 9c5dd5b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12971
Motivation
fix doc
Modifications
Clarify docs for CronWorkflow field startingDeadlineSeconds
Verification
Run locally and check.