Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): clarify CronWorkflow startingDeadlineSeconds. Fixes #12971 #13280

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

qingfeng777
Copy link
Contributor

Fixes #12971

Motivation

fix doc

Modifications

Clarify docs for CronWorkflow field startingDeadlineSeconds

Verification

Run locally and check.

@agilgur5 agilgur5 self-assigned this Jun 29, 2024
@agilgur5 agilgur5 self-requested a review June 29, 2024 15:54
@agilgur5 agilgur5 added area/docs Incorrect, missing, or mistakes in docs area/cron-workflows labels Jun 29, 2024
@agilgur5 agilgur5 changed the title fix: Clarify docs for CronWorkflow startingDeadlineSeconds. Fixes #12971 fix(docs): clarify CronWorkflow startingDeadlineSeconds. Fixes #12971 Jun 29, 2024
Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further simplifications & style changes below

docs/cron-workflows.md Outdated Show resolved Hide resolved
docs/cron-workflows.md Outdated Show resolved Hide resolved
docs/cron-workflows.md Show resolved Hide resolved
qingfeng777 and others added 3 commits July 1, 2024 17:34
…oproj#12971

Co-authored-by: Neile Havens <neilehavens@gmail.com>
Signed-off-by: qingfeng777 <251098199@qq.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the clarification to the docs

@agilgur5 agilgur5 enabled auto-merge (squash) July 1, 2024 21:39
@agilgur5 agilgur5 merged commit 9c5dd5b into argoproj:main Jul 1, 2024
16 checks passed
agilgur5 pushed a commit that referenced this pull request Jul 6, 2024
… (#13280)

Signed-off-by: qingfeng777 <251098199@qq.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Co-authored-by: Neile Havens <neilehavens@gmail.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
(cherry picked from commit 9c5dd5b)
agilgur5 pushed a commit that referenced this pull request Jul 6, 2024
… (#13280)

Signed-off-by: qingfeng777 <251098199@qq.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Co-authored-by: Neile Havens <neilehavens@gmail.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
(cherry picked from commit 9c5dd5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cron-workflows area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify docs for CronWorkflow startingDeadlineSeconds
2 participants