Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(offloading): Change offloaded nodes datatype to JSON to support 1GB. Fixes #2246 #2250

Merged
merged 3 commits into from
Feb 18, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 17, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Fixes #2246

This can be merged as soon as builds are green and should be manually back-ported to v2.5

@alexec alexec added this to In progress in Argo Workflows OSS Kanban Board via automation Feb 17, 2020
@alexec alexec added this to the v2.5 milestone Feb 17, 2020
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d309d5c). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2250   +/-   ##
=========================================
  Coverage          ?   11.35%           
=========================================
  Files             ?       71           
  Lines             ?    27983           
  Branches          ?        0           
=========================================
  Hits              ?     3178           
  Misses            ?    24400           
  Partials          ?      405
Impacted Files Coverage Δ
persist/sqldb/migrate.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d309d5c...5f93a39. Read the comment docs.

@alexec alexec marked this pull request as ready for review February 18, 2020 16:39
Argo Workflows OSS Kanban Board automation moved this from In progress to Reviewer approved Feb 18, 2020
@alexec alexec merged commit 63858ea into argoproj:master Feb 18, 2020
Argo Workflows OSS Kanban Board automation moved this from Reviewer approved to Done Feb 18, 2020
@alexec alexec deleted the nodes-json branch February 18, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Offloaded nodes does not fit into MySQL TEXT field
3 participants