feat(auth): Add the workflow's creator as a label. Closes #2437 #2488
Conversation
| @@ -61,5 +71,5 @@ func GetAuthString() string { | |||
| if err != nil { | |||
| log.Fatal(err) | |||
| } | |||
| return authString | |||
| return fmt.Sprintf("v2/%s/%s", authString, GetUser().Name) | |||
There was a problem hiding this comment.
this creates strange looking, but valid tokens:
v2/Bearer 34534==/alex
| </p> | ||
| )} | ||
| <p> | ||
| <i className='fa fa-info-circle' /> You appear to be <b> logged {maybeLoggedIn() ? 'in as ' + this.username : 'out'}</b>. It may not be necessary to login |
There was a problem hiding this comment.
this is really for debugging purposes
Codecov Report
@@ Coverage Diff @@
## master #2488 +/- ##
==========================================
+ Coverage 11.22% 11.30% +0.07%
==========================================
Files 83 75 -8
Lines 32696 31248 -1448
==========================================
- Hits 3671 3533 -138
+ Misses 28525 27244 -1281
+ Partials 500 471 -29
Continue to review full report at Codecov.
|
|
@jessesuen before I ask for reviews - can I check with you on whether or not this is the correct direction philosopically? |
|
Kudos, SonarCloud Quality Gate passed!
|
| header := getHeader(md, "authorization") | ||
| if strings.HasPrefix(header, "v2/") { | ||
| parts := strings.SplitN(header, "/", 3) | ||
| return parts[1], wfv1.User{Name: parts[2]} |
There was a problem hiding this comment.
malformed token would panic
Checklist:
"fix(controller): Updates such and such. Fixes #1234".